Merge stable to master #543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assert that 100,000 lines (instead of 10,000 lines) can complete in 2 seconds.
The inline Ruby wanted versions like 2.3.4, but it was getting int-mapped versions like 2003004000. That broke the logic in the inline Ruby completely, so everything was treated as having a major version wayyyy above 3, hence "modern". This is why we unit-test.
It's not installed on either Mac or Linux CI boxes
This reverts commit f1bb5af. DRY. Not a big deal either way.
This reverts commit 7411333. We don't need coreutils. I used $PWD to eliminate the need for `realpath`, and I've implemented `timeout` for OSX. If the Linux CI is missing `timeout`, I'll push another commit to let it use the OSX implementation.
…to fix-backup-timing
We can't rely on the customer's admin box (which isn't the appliance) having any actual programming languages on it. But we can use sed, and sed is good enough to simulate dirname with a single fork+exec. This commit also fixes future versions: 2.20.x, 3.x, etc. All future versions will be >= 2.19.3, so we just combine the 2.19 check with the future-versions check.
The shell `version` function treats garbage as equivalent to 0.0.0, rather than throwing exceptions and exiting with an error code, as the Ruby implementation did. So roll the invalid-input tests into the use-the-old-version test.
The data we're sorting has clusters of duplicates in the input, because `dirname` reduces all repos in the same network (i.e., forks) to the same network path. Running `uniq` before `sort` eliminates those duplicates, which means `sort` requires less CPU and RAM to do its thing. We still need `uniq` on the output end, because there's no guarantee that all duplicates in the input are clustered. I've run tests, and the cost of `uniq` is small enough that it does no harm if the input has no duplicates at all.
We brought back coreutils, which provides it.
Fix `ghe-backup-repositories` performance for large instances
Bump version: 2.19.2
snh
approved these changes
Feb 1, 2020
Closed
`dgit-cluster-backup-routes` needs to use the same fake gist route as `test/testlib.sh`. Now it does.
oakeyc
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did PR #541 on stable branch, moving this changes back to master