Skip to content

Adding start, end and run time for backup #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 11, 2023
Merged

Conversation

vn0bbin
Copy link
Contributor

@vn0bbin vn0bbin commented Sep 16, 2022

This will help to check how much time it took to complete the backup.

@vn0bbin
Copy link
Contributor Author

vn0bbin commented Sep 16, 2022

@djdefi can you please let me know what's the issue here?

@djdefi djdefi requested a review from a team September 16, 2022 19:30
@djdefi
Copy link
Member

djdefi commented Sep 16, 2022

Hey there @vn0bbin thanks for the contribution! I've requested a review from the team responsible for backup-utils currently.

It looks like the Lint code base check is complaining about some existing shellcheck messages, which are unrelated to your contribution. This is not a required check, so I don't think there is any action needed on your part.

@vn0bbin
Copy link
Contributor Author

vn0bbin commented Sep 16, 2022

Got it, Thanks much!

Copy link
Contributor

@donal donal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vn0bbin Thanks for submitting this — I've made a couple of minor suggestions.

Making suggested changes [here](github#956 (review))
@vn0bbin
Copy link
Contributor Author

vn0bbin commented Sep 20, 2022

@donal Thanks for the suggestions. Made the required changes, please review it and let me know. Thanks

@vn0bbin
Copy link
Contributor Author

vn0bbin commented Oct 21, 2022

@donal Is there anything else required to get this PR merged?

@vn0bbin
Copy link
Contributor Author

vn0bbin commented Dec 16, 2022

@donal Anything else needed to merge this PR?

Copy link
Contributor

@gamefiend gamefiend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on this, approved.

Thanks for your contribution!

@gamefiend gamefiend merged commit c6b6ba2 into github:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants