-
Notifications
You must be signed in to change notification settings - Fork 616
Adding start, end and run time for backup #956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@djdefi can you please let me know what's the issue here? |
Hey there @vn0bbin thanks for the contribution! I've requested a review from the team responsible for It looks like the Lint code base check is complaining about some existing |
Got it, Thanks much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vn0bbin Thanks for submitting this — I've made a couple of minor suggestions.
Making suggested changes [here](github#956 (review))
@donal Thanks for the suggestions. Made the required changes, please review it and let me know. Thanks |
@donal Is there anything else required to get this PR merged? |
@donal Anything else needed to merge this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay on this, approved.
Thanks for your contribution!
This will help to check how much time it took to complete the backup.