This repository has been archived by the owner on Jan 5, 2023. It is now read-only.
Extractor: give the go.mod comment groups a source location #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-mc
previously approved these changes
Jun 27, 2020
max-schaefer
suggested changes
Jun 29, 2020
| import go | ||
|
|
||
| from CommentGroup cg | ||
| select cg.getLocation() |
There was a problem hiding this comment.
The test runner automatically includes the location in the test output, so in general you shouldn't need to explicitly select locations in tests.
extractor/gomodextractor.go
Outdated
| extractGoModComment(tw, comment, grouplbl, idx) | ||
| idx++ | ||
| commentEndCol := comment.Start.LineRune + len(comment.Token) |
There was a problem hiding this comment.
Our end positions are generally inclusive, so I think this should be
Suggested change
| commentEndCol := comment.Start.LineRune + len(comment.Token) | |
| commentEndCol := comment.Start.LineRune + len(comment.Token) - 1 |
There was a problem hiding this comment.
Also, do I interpret the test failures on Windows correctly to mean that comment.Token includes a \r if the line ending is \r\n? If so, we'll probably want to chop it off.
smowton
force-pushed
the
smowton/fix/go-mod-comment-blocks
branch
2 times, most recently
from
8cd41b5
to
90b06c2
Compare
The comment group is now omitted entirely if empty, and otherwise delimits the range of the comments ascribed to this group.
smowton
force-pushed
the
smowton/fix/go-mod-comment-blocks
branch
from
90b06c2
to
ce417aa
Compare
|
The |
max-schaefer
suggested changes
Jun 30, 2020
extractor/gomodextractor.go
Outdated
| } | ||
| } | ||
|
|
||
| func stripTrailingCR(input string) string { |
There was a problem hiding this comment.
Maybe just use https://golang.org/pkg/strings/#TrimSuffix?
This means the source locations and lengths for comments will be the same on Windows and Unix-like platforms. Note this works around golang/go#39913
smowton
force-pushed
the
smowton/fix/go-mod-comment-blocks
branch
from
ce417aa
to
0252c72
Compare
|
@max-schaefer done |
max-schaefer
approved these changes
Jun 30, 2020
ceh
pushed a commit
to ceh-forks/codeql-go
that referenced
this pull request
Jul 22, 2020
Makefile improvements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment group is now omitted entirely if empty, and otherwise delimits the range of the comments ascribed to this group.
Pre-emptive reviewer response: yes, really, Go's
mathpackage only providesMinandMaxfor float types, so you either have to cast back and forth, take a dependency such asgithub.com/pkg/mathor write your ownIntMinandIntMax.