Autobuilder: always check the vendor directory works and if go.mod exists #312
Conversation
This only applies for module files for which no Go version has been specified; Go will assume these should be parsed with the latest Go version, which will cause them to fail if the vendor directory has been generated with an old version of Go, as the vendor/modules.txt will not meet the new requirements for consistency.
This means dependency installation is still attempted when a vendor directory is inconsistent.
These now follow the same route: * Run a default or custom build script * If needed, check if vendor/ is usable * If it isn't, or if their build failed, install dependencies using go get etc This commit shouldn't cause any behavioural change.
Also don't pass a blank argument to `go` when using an old version.
smowton
force-pushed
the
smowton/autobuilder-fixes-fixed-further
branch
from
a6a8588 to
b13b54f
Compare
| @@ -508,8 +508,13 @@ func main() { | |||
| } | |||
|
|
|||
| var cmd *exec.Cmd | |||
| log.Printf("Running extractor command '%s %s ./...' from directory '%s'.\n", extractor, modMode, cwd) | |||
| cmd = exec.Command(extractor, modMode.String(), "./...") | |||
| if depMode == GoGetWithModules && modMode.String() != "" { | |||
There was a problem hiding this comment.
| if depMode == GoGetWithModules && modMode.String() != "" { | |
| if depMode == GoGetWithModules && modMode != ModUnset { |
That said, modMode can be unset by modMode = modModIfAvailable, so it's probably worth having a separate thing to track that.
Or, actually, we could move the logic for versions into ModMode.String() and then it would make everything else a bit nicer.
The semver package requires versions of the form v1.2.3, and unhelpfully evaluates any malformed versions as equal.
| case ModMod: | ||
| return "-mod=mod" | ||
| if semver.Compare(getEnvGoVersion(), "1.14") < 0 { |
There was a problem hiding this comment.
You pass version above, but you don't seem to use it?
There was a problem hiding this comment.
Ah sorry this is fixed in the commit after
| @@ -58,6 +59,15 @@ func getEnvGoVersion() string { | |||
| return goVersion | |||
| } | |||
|
|
|||
| // Returns the current Go version in semver format, e.g. v1.14.4 | |||
| func getEnvGoSemVer() string { | |||
There was a problem hiding this comment.
I don't think there's any reason to keep getEnvGoVersion around, is there? I probably could have tried to test the version support...
There was a problem hiding this comment.
Only for reporting the version at the top in the same terms as go version returns it, which I think is reasonable
|
Re-tested this afternoon with latest changes -- all looking good. |
This is #310 with additions:
-modwhen go.mod existscheckVendor(optional, could drop)Locally verified this fixes a further 24 projects; proceeding to build a dist and check on all projects.