Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LGTM.com - false positive - C++ std::make_unique is considered as a stack variable #5709

Closed
pavelkryukov opened this issue Apr 17, 2021 · 4 comments · Fixed by #5723
Closed

LGTM.com - false positive - C++ std::make_unique is considered as a stack variable #5709

pavelkryukov opened this issue Apr 17, 2021 · 4 comments · Fixed by #5723
Assignees
@MathiasVP
Labels
acknowledged GitHub staff acknowledges this issue C++ false-positive

Comments

@pavelkryukov
Copy link

Description of the false positive

std::make_unique is considered to create stack-variable, while it allocates everything on heap.

URL to the alert on the project page on LGTM.com

https://lgtm.com/projects/g/MIPT-ILab/mipt-mips/snapshot/7da5a371e3783c87709762d579ad3553ee537802/files/simulator/infra/ports/module.h#xe62a5e4a1bee1e6a:1
@hmakholm hmakholm added the C++ label Apr 19, 2021
@rdmarsh2 rdmarsh2 added the acknowledged GitHub staff acknowledges this issue label Apr 19, 2021
@rdmarsh2
Copy link
Contributor

That does look like a false positive.

@MathiasVP this might be an unintended consequence of #5607 - can you take a look tomorrow?

This was referenced Apr 20, 2021
Merged
Closed
@jbj jbj closed this as completed in #5723 Apr 20, 2021
@MathiasVP MathiasVP reopened this Apr 20, 2021
@MathiasVP
Copy link
Contributor

(Reopening the issue as another PR was incorrectly marked as closing this issue)

@MathiasVP MathiasVP mentioned this issue Apr 20, 2021
Merged
@jbj
Copy link
Contributor

jbj commented Apr 20, 2021

Fixed by #5726.

@jbj jbj closed this as completed Apr 20, 2021
@pavelkryukov
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MathiasVP MathiasVP

Labels
acknowledged GitHub staff acknowledges this issue C++ false-positive
Projects
None yet
Milestone
No milestone
5 participants
@jbj @rdmarsh2 @MathiasVP @pavelkryukov @hmakholm