LGTM.com - false positive `js/trivial-conditional`

[sunafterrainwm]

Description of the false positive
argument allowUnknown may be undefined, false, or true, !allowUnknown isn't "always evaluates to true".

URL to the alert on the project page on LGTM.com
https://lgtm.com/projects/g/sunafterrainwm/LilyWhiteBot-typescript/snapshot/68356fa5c61585d878e0605f3941519513ab2793/files/src/lib/eventemitter2.ts#x20af7a89c89a9eee:1

[aibaars]

Thanks for the report. I'm not too familiar with typescript but it looks like you're right. I'll pass it on to the team.

[asgerf]

Hi @sunafterrainwm,

The alert is generated because that argument is omitted at every call site to that function (hence is always undefined) and the function is not made accessible outside the file. We recognize that there's a usability issue with this query as this behaviour isn't obvious.

However, our focus is on improving the security queries, and this is not considered a security query, so the issue will not be prioritised for the time being.