C++: Handle block assignments #10031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
These can under some circumstances be generated by the frontend as part of compiler generated copy constructors and assignment operators.
jketema
added
the
depends on internal PR
MathiasVP
approved these changes
Aug 15, 2022
| } | ||
|
|
||
| final override Instruction getFirstInstruction() { | ||
| // The operand evaluation order should since block assignments behave like memcpy. |
There was a problem hiding this comment.
This comment reads a bit weird. Did you mean "[...] should be left-to-right [...]"?
There was a problem hiding this comment.
Woops:
Suggested change
| // The operand evaluation order should since block assignments behave like memcpy. | |
| // The operand evaluation order should not matter since block assignments behave like memcpy. |
There was a problem hiding this comment.
Does that make more sense?
There was a problem hiding this comment.
That makes a lot of sense, yes!
| @@ -1450,8 +1450,6 @@ class TranslatedAssignExpr extends TranslatedNonConstantExpr { | |||
| result = this.getLeftOperand().getResult() | |||
| } | |||
|
|
|||
| abstract Instruction getStoredValue(); | |||
There was a problem hiding this comment.
Wat. This was just an unused abstract member predicate lying around? Well spotted!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block assignments may occur as part of default copy/move constructors and assignment operators that are generated by the frontend. The assignments operate like
memcpy, where the type of the source is used determine the size of what needs to be copied.