Java: Move sink-constraints into the configuration in NumericCastTainted.ql. #10084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dca looks very uneventful. |
aschackmull
added
the
no-change-note-required
atorralba
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exclusion of right-shifted variables on sinks is probably better as a sanitizer, so move it there. That should help performance a bit and possibly also remove some FPs.
Also, there was a somewhat arbitrary-looking restriction that the sink has to be a variable access. I'm not going to consider whether that restriction ought to lifted (it's probably fine to keep), but we might as well make it explicit and move it into the configuration to gain some performance.