parameterised modules in the QL language reference #10088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginsbach
force-pushed
the
parameterisedModules
branch
4 times, most recently
from
c4b87a6 to
b6fd66a
Compare
ginsbach
force-pushed
the
parameterisedModules
branch
from
b6fd66a to
e8a1925
Compare
felicitymay
previously approved these changes
Aug 26, 2022
felicitymay
added
the
ready-for-doc-review
Co-authored-by: Felicity Chapman <felicitymay@github.com>
Co-authored-by: Felicity Chapman <felicitymay@github.com>
Co-authored-by: Felicity Chapman <felicitymay@github.com>
Co-authored-by: Felicity Chapman <felicitymay@github.com>
Co-authored-by: Felicity Chapman <felicitymay@github.com>
Co-authored-by: Felicity Chapman <felicitymay@github.com>
Co-authored-by: Felicity Chapman <felicitymay@github.com>
Co-authored-by: Felicity Chapman <felicitymay@github.com>
Co-authored-by: Felicity Chapman <felicitymay@github.com>
@felicitymay Thank you for all these suggestions, I have attempted to address them one-by-one with many new commits. |
felicitymay
previously approved these changes
Aug 30, 2022
There was a problem hiding this comment.
@ginsbach - thank you so much for taking the time to address my review comments 💖
I spotted a couple of instances of "parameterised" but otherwise this looks ready to merge 🚀
Co-authored-by: Felicity Chapman <felicitymay@github.com>
Co-authored-by: Felicity Chapman <felicitymay@github.com>
felicitymay
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft of the reference entry for parameterised modules and signatures.
fixes https://github.com/github/codeql-core/issues/2447