C#: Replace clears content with CSV summaries. #10127

michaelnebel · 2022-08-22T07:31:02Z

The shared library code already supports WithoutContent, which can be used to replace the override predicate clearsContent. Only parsing and printing functionality needed to be implemented for C# to leverage the shared withoutContent functionality.

That is, in this PR

Implement the last small remaining C# language specific parts to leverage the withoutContent functionality.
Implement the last small remaining C# language specific parts to leverage the withContent functionality.
Replace all clearsContent predicates overrides with flow summaries. Note that this is practically infeasible due to the implementation of the existing clearsContent. An assumption was made in the original code that all classes that implements the IEnumerable interface and also has a Clear method, then the semantics of Clear would be that no flow is propagated via Clear. As a replacement, flow summaries for Clear has been introduced for many interfaces and classes in the .NET Runtime. For all practical reasons this is probably sufficiently good.
Update flow summaries test cases.
Delete the obsolete clearsContent framework code.

github-actions · 2022-08-22T07:35:02Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",4,11809,43,7
+    System,"``System.*``, ``System``",4,11810,43,7
-    Totals,,4,12370,375,7
+    Totals,,4,12371,375,7

Changes to framework-coverage-csharp.csv:

- System,43,4,11809,,1,1,1,,4,,33,3,1,3,9867,1942
+ System,43,4,11810,,1,1,1,,4,,33,3,1,3,9867,1943

github-actions · 2022-08-22T13:57:47Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",4,11809,43,7
+    System,"``System.*``, ``System``",4,11861,43,7
-    Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,554,138,
+    Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,555,138,
-    Totals,,4,12370,375,7
+    Totals,,4,12423,375,7

Changes to framework-coverage-csharp.csv:

- Microsoft.VisualBasic,,,9,,,,,,,,,,,,5,4
+ Microsoft.VisualBasic,,,10,,,,,,,,,,,,5,5
- System,43,4,11809,,1,1,1,,4,,33,3,1,3,9867,1942
+ System,43,4,11861,,1,1,1,,4,,33,3,1,3,9867,1994

csharp/ql/lib/semmle/code/csharp/frameworks/system/Collections.qll

github-actions · 2022-08-22T14:07:06Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",4,11809,43,7
+    System,"``System.*``, ``System``",4,11861,43,7
-    Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,554,138,
+    Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,555,138,
-    Totals,,4,12370,375,7
+    Totals,,4,12423,375,7

Changes to framework-coverage-csharp.csv:

- Microsoft.VisualBasic,,,9,,,,,,,,,,,,5,4
+ Microsoft.VisualBasic,,,10,,,,,,,,,,,,5,5
- System,43,4,11809,,1,1,1,,4,,33,3,1,3,9867,1942
+ System,43,4,11861,,1,1,1,,4,,33,3,1,3,9867,1994

github-actions · 2022-08-23T09:17:02Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",4,11809,43,7
+    System,"``System.*``, ``System``",4,11858,43,7
-    Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,554,138,
+    Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,555,138,
-    Totals,,4,12370,375,7
+    Totals,,4,12420,375,7

Changes to framework-coverage-csharp.csv:

- Microsoft.VisualBasic,,,9,,,,,,,,,,,,5,4
+ Microsoft.VisualBasic,,,10,,,,,,,,,,,,5,5
- System,43,4,11809,,1,1,1,,4,,33,3,1,3,9867,1942
+ System,43,4,11858,,1,1,1,,4,,33,3,1,3,9867,1991

github-actions · 2022-08-23T09:33:43Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",4,11809,43,7
+    System,"``System.*``, ``System``",4,11858,43,7
-    Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,554,138,
+    Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,555,138,
-    Totals,,4,12370,375,7
+    Totals,,4,12420,375,7

Changes to framework-coverage-csharp.csv:

- Microsoft.VisualBasic,,,9,,,,,,,,,,,,5,4
+ Microsoft.VisualBasic,,,10,,,,,,,,,,,,5,5
- System,43,4,11809,,1,1,1,,4,,33,3,1,3,9867,1942
+ System,43,4,11858,,1,1,1,,4,,33,3,1,3,9867,1991

github-actions · 2022-08-23T12:20:20Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",4,11809,43,7
+    System,"``System.*``, ``System``",4,11858,43,7
-    Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,554,138,
+    Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,555,138,
-    Totals,,4,12370,375,7
+    Totals,,4,12420,375,7

Changes to framework-coverage-csharp.csv:

- Microsoft.VisualBasic,,,9,,,,,,,,,,,,5,4
+ Microsoft.VisualBasic,,,10,,,,,,,,,,,,5,5
- System,43,4,11809,,1,1,1,,4,,33,3,1,3,9867,1942
+ System,43,4,11858,,1,1,1,,4,,33,3,1,3,9867,1991

hvitved

LGTM; just a small suggestion. We should also do a DCA run for C#.

csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImplSpecific.qll

github-actions · 2022-08-29T14:20:35Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",4,11809,43,7
+    System,"``System.*``, ``System``",4,11858,43,7
-    Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,554,138,
+    Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,555,138,
-    Totals,,4,12370,375,7
+    Totals,,4,12420,375,7

Changes to framework-coverage-csharp.csv:

- Microsoft.VisualBasic,,,9,,,,,,,,,,,,5,4
+ Microsoft.VisualBasic,,,10,,,,,,,,,,,,5,5
- System,43,4,11809,,1,1,1,,4,,33,3,1,3,9867,1942
+ System,43,4,11858,,1,1,1,,4,,33,3,1,3,9867,1991

github-actions · 2022-08-30T08:01:49Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",4,11809,43,7
+    System,"``System.*``, ``System``",4,11858,43,7
-    Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,554,138,
+    Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,555,138,
-    Totals,,4,12370,375,7
+    Totals,,4,12420,375,7

Changes to framework-coverage-csharp.csv:

- Microsoft.VisualBasic,,,9,,,,,,,,,,,,5,4
+ Microsoft.VisualBasic,,,10,,,,,,,,,,,,5,5
- System,43,4,11809,,1,1,1,,4,,33,3,1,3,9867,1942
+ System,43,4,11858,,1,1,1,,4,,33,3,1,3,9867,1991

michaelnebel · 2022-08-30T08:03:12Z

Needed to rebase to execute DCA.

michaelnebel · 2022-08-31T07:01:05Z

@hvitved: Ran DCA twice yesterday. There a seems to some indication that some projects are slightly affected by performance (but not in alerts). Need to rebase again due to a rebase conflict. Will make a single threaded DCA execution with tuple counting this time around.

github-actions · 2022-08-31T07:36:48Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",4,12081,65,7
+    System,"``System.*``, ``System``",4,12130,65,7
-    Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,555,138,
+    Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,556,138,
-    Totals,,4,12643,397,7
+    Totals,,4,12693,397,7

Changes to framework-coverage-csharp.csv:

- Microsoft.VisualBasic,,,9,,,,,,,,,,,,5,4
+ Microsoft.VisualBasic,,,10,,,,,,,,,,,,5,5
- System,65,4,12081,,8,8,9,,4,,33,3,1,3,10139,1942
+ System,65,4,12130,,8,8,9,,4,,33,3,1,3,10139,1991

…case.

github-actions · 2022-09-02T13:20:53Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",4,12081,65,7
+    System,"``System.*``, ``System``",4,12130,65,7
-    Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,555,138,
+    Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,556,138,
-    Totals,,4,12643,397,7
+    Totals,,4,12693,397,7

Changes to framework-coverage-csharp.csv:

- Microsoft.VisualBasic,,,9,,,,,,,,,,,,5,4
+ Microsoft.VisualBasic,,,10,,,,,,,,,,,,5,5
- System,65,4,12081,,8,8,9,,4,,33,3,1,3,10139,1942
+ System,65,4,12130,,8,8,9,,4,,33,3,1,3,10139,1991

github-actions · 2022-09-06T07:37:06Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",4,12081,65,7
+    System,"``System.*``, ``System``",4,12131,65,7
-    Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,555,138,
+    Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,556,138,
-    Totals,,4,12643,397,7
+    Totals,,4,12694,397,7

Changes to framework-coverage-csharp.csv:

- Microsoft.VisualBasic,,,9,,,,,,,,,,,,5,4
+ Microsoft.VisualBasic,,,10,,,,,,,,,,,,5,5
- System,65,4,12081,,8,8,9,,4,,33,3,1,3,10139,1942
+ System,65,4,12131,,8,8,9,,4,,33,3,1,3,10139,1992

michaelnebel · 2022-09-08T07:25:18Z

DCA looks good after fixing the missing bi-directional imports (merging now):

Merge commit: e265b07

github-actions bot added the C# label Aug 22, 2022

github-advanced-security bot found potential problems Aug 22, 2022

View reviewed changes

csharp/ql/lib/semmle/code/csharp/frameworks/system/Collections.qll Fixed Show fixed Hide fixed

michaelnebel force-pushed the csharp/clearscontent branch from 724c7fd to ab028f2 Compare August 22, 2022 14:04

michaelnebel force-pushed the csharp/clearscontent branch from ab028f2 to 4746c34 Compare August 23, 2022 09:14

michaelnebel force-pushed the csharp/clearscontent branch from 4746c34 to 1cf0859 Compare August 23, 2022 09:30

michaelnebel force-pushed the csharp/clearscontent branch from 1cf0859 to 16a3918 Compare August 23, 2022 12:17

github-actions bot added Java Ruby Swift labels Aug 23, 2022

michaelnebel marked this pull request as ready for review August 24, 2022 06:41

michaelnebel requested review from a team as code owners August 24, 2022 06:41

michaelnebel added the no-change-note-required This PR does not need a change note label Aug 24, 2022

hvitved reviewed Aug 29, 2022

View reviewed changes

csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImplSpecific.qll Show resolved Hide resolved

csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImplSpecific.qll Show resolved Hide resolved

michaelnebel requested a review from hvitved August 29, 2022 14:27

hvitved previously approved these changes Aug 29, 2022

View reviewed changes

michaelnebel dismissed hvitved’s stale review via 342e851 August 30, 2022 07:59

michaelnebel force-pushed the csharp/clearscontent branch from dc8cf81 to 342e851 Compare August 30, 2022 07:59

michaelnebel requested a review from hvitved August 30, 2022 08:02

hvitved previously approved these changes Aug 31, 2022

View reviewed changes

michaelnebel dismissed hvitved’s stale review via 5557f98 August 31, 2022 07:33

michaelnebel force-pushed the csharp/clearscontent branch from 342e851 to 5557f98 Compare August 31, 2022 07:33

michaelnebel added 11 commits September 2, 2022 15:17

C#: Parsing of WithoutElement.

8234a50

C#: CSV Printing of WithoutElement content.

e3bfc4b

C#: Add summary for System.Text.StringBuilder.Clear.

80f8928

C#: Add models as data models for Clear.

f43feac

C#: Update flow summaries test expected output.

2ae2008

C#: Delete clears content test case.

19da00a

C#: Remove clearsContent predicate from the framework code.

ecce30e

Java/Ruby/Swift: Sync files.

5511bc8

C#: Support 'WithElement'.

022cbfa

C#: Add with element example and update existing line numbers in test…

e7e78dc

…case.

C#: Add WithElement summary for Reverse and update expected test output.

9c5a6dd

michaelnebel force-pushed the csharp/clearscontent branch from 5557f98 to 9c5a6dd Compare September 2, 2022 13:17

C#: Add missing bi-directional imports.

0e52d2c

michaelnebel requested a review from hvitved September 6, 2022 08:33

hvitved approved these changes Sep 6, 2022

View reviewed changes

michaelnebel merged commit e265b07 into github:main Sep 8, 2022

michaelnebel deleted the csharp/clearscontent branch September 8, 2022 07:26

owen-mc added the DataFlow Library label Nov 23, 2022

owen-mc added a commit to owen-mc/codeql that referenced this pull request Nov 29, 2022

Update shared library files for go to PR github#10127

ee6862c

Merge commit: e265b07

owen-mc added a commit to owen-mc/codeql that referenced this pull request Nov 29, 2022

Update shared library files for go to PR github#10127

99314bd

Merge commit: e265b07

owen-mc added a commit to owen-mc/codeql that referenced this pull request Nov 29, 2022

Update shared library files for go to PR github#10127

a2df8df

Merge commit: e265b07

owen-mc added a commit to owen-mc/codeql that referenced this pull request Nov 29, 2022

Update shared library files for go to PR github#10127

569da2d

Merge commit: e265b07

C#: Replace clears content with CSV summaries. #10127

C#: Replace clears content with CSV summaries. #10127

Uh oh!

Conversation

michaelnebel commented Aug 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 22, 2022

csharp

Generated file changes for csharp

Uh oh!

github-actions bot commented Aug 22, 2022

csharp

Generated file changes for csharp

Uh oh!

Uh oh!

github-actions bot commented Aug 22, 2022

csharp

Generated file changes for csharp

Uh oh!

github-actions bot commented Aug 23, 2022

csharp

Generated file changes for csharp

Uh oh!

github-actions bot commented Aug 23, 2022

csharp

Generated file changes for csharp

Uh oh!

github-actions bot commented Aug 23, 2022

csharp

Generated file changes for csharp

Uh oh!

hvitved left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 29, 2022

csharp

Generated file changes for csharp

Uh oh!

github-actions bot commented Aug 30, 2022

csharp

Generated file changes for csharp

Uh oh!

michaelnebel commented Aug 30, 2022

Uh oh!

michaelnebel commented Aug 31, 2022

Uh oh!

github-actions bot commented Aug 31, 2022

csharp

Generated file changes for csharp

Uh oh!

github-actions bot commented Sep 2, 2022

csharp

Generated file changes for csharp

Uh oh!

github-actions bot commented Sep 6, 2022

csharp

Generated file changes for csharp

Uh oh!

michaelnebel commented Sep 8, 2022

Uh oh!

Uh oh!

michaelnebel commented Aug 22, 2022 •

edited

Loading