Skip to content

Go: fix tracing spec for windows #10147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2022
Merged

Go: fix tracing spec for windows #10147

merged 1 commit into from
Aug 24, 2022

Conversation

aibaars
Copy link
Contributor

@aibaars aibaars commented Aug 23, 2022 •
edited
Loading

This should fix errors like:

[T 17:40:07 5848] Unable to invoke extractor using command line ""C:\hostedtoolcache\windows\CodeQL\0.0.0-20220811\x64\codeql\go\tools\win64\go-extractorgo-extractor.exe" --mimic "c:\hostedtoolcache\windows\go\1.19.0\x64\bin\go.exe" build main.go".

@aibaars aibaars requested a review from a team as a code owner August 23, 2022 18:00
@github-actions github-actions bot added the Go label Aug 23, 2022
@henrymercer henrymercer mentioned this pull request Aug 23, 2022
Merged
3 tasks
@smowton
Copy link
Contributor

smowton commented Aug 24, 2022

Tested on Windows and confirmed this fixes CLI use of manually-specified build commands

@aibaars aibaars merged commit acff279 into main Aug 24, 2022
@aibaars aibaars deleted the aibaars-fix-go branch August 24, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smowton smowton smowton approved these changes

@henrymercer henrymercer henrymercer approved these changes

Assignees
No one assigned
Labels
Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aibaars @smowton @henrymercer