Swift: Model property getters, setters and observers as callables #10155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Part of https://github.com/github/codeql-c-team/issues/903.)
This is the first of two dataflow PRs for field flow for Swift. It models property getters, setters, and observers as callables in the dataflow library. At the moment, this doesn't give us any field flow, but once we add read and store steps the dataflow library will see these getters and setters as read and writes steps.
Note that there's a slight error in the way we model the arguments to a
didSet
observer: we're passing the new value as an argument to thedidSet
observer, but thedidSet
observer actually takes the old value as an argument. I plan on fixing this in a later PR.Finally, this PR also fixes an issue with multiple
toString
s. ThetoString
predicate had multiple results becauseNormalParameterNode
was extendingSsaDefinitionNode
instead ofSsaDefinitionNodeImpl
.