SSA: Make shared library a parameterized module #10203
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * ``` | ||
| */ | ||
| module Make<SsaInputSig Input> { | ||
| private import Input |
Check warning
Code scanning / CodeQL
QL-for-QL encountered an internal consistency error
hvitved
force-pushed
the
ssa/param-module
branch
from
5195825 to
a0574b0
Compare
| * ``` | ||
| */ | ||
| module Make<InputSig Input> { | ||
| private import Input |
Check warning
Code scanning / CodeQL
QL-for-QL encountered an internal consistency error
| * ``` | ||
| */ | ||
| module Make<InputSig Input> { | ||
| private import Input |
Check warning
Code scanning / CodeQL
QL-for-QL encountered an internal consistency error
| * ``` | ||
| */ | ||
| module Make<InputSig Input> { | ||
| private import Input |
Check warning
Code scanning / CodeQL
QL-for-QL encountered an internal consistency error
hvitved
force-pushed
the
ssa/param-module
branch
2 times, most recently
from
ad1445a to
1710326
Compare
hvitved
force-pushed
the
ssa/param-module
branch
from
1710326 to
7a2d434
Compare
|
Are these predicates meant to be publically usable? If they are then they will disappear from the online docs. |
Nope. Each language should provide its own public layer on top. |
This PR changes
SsaImplCommon.qllto be a parameterized module. This means that we no longer need 4 copies for C#, but we still need a copy per language (I plan to change that in a follow-up PR).