Dataflow: Fix implicit reads in taint tracking when FlowStates are used #10360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
previously approved these changes
Sep 8, 2022
atorralba
changed the title
aschackmull
reviewed
Sep 9, 2022
aschackmull
reviewed
Sep 9, 2022
javascript/ql/lib/change-notes/2022-09-08-implicit-read-flowstates.md
Outdated
Show resolved
Hide resolved
atorralba
force-pushed
the
atorralba/fix-taint-implicit-reads
branch
from
6f9b856 to
1078cf0
Compare
aschackmull
approved these changes
Sep 9, 2022
owen-mc
added a commit
to owen-mc/codeql
that referenced
this pull request
Nov 29, 2022
Merge commit: 569fad6
owen-mc
added a commit
to owen-mc/codeql
that referenced
this pull request
Nov 29, 2022
Merge commit: 569fad6
owen-mc
added a commit
to owen-mc/codeql
that referenced
this pull request
Nov 29, 2022
Merge commit: 569fad6
owen-mc
added a commit
to owen-mc/codeql
that referenced
this pull request
Nov 29, 2022
Merge commit: 569fad6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit adds a test that fails because implicit reads weren't allowed in sinks or additional taint steps that used FlowStates.
The second commit fixes the issue.