TS: fix a case of infinite type expansion #1059
Conversation
| * Returns `true` if the properties of the given type can safely be extracted | ||
| * without restricting expansion depth. | ||
| * | ||
| * This predicate is very approximate, and considers all unions, intersections, |
There was a problem hiding this comment.
Very approximate indeed.
Maybe we should look into special casing on some common cases later.
There was a problem hiding this comment.
It shouldn't be that bad. The structure of a type is still extracted, this just determines whether its properties are. So for a type like Buffer | string, we can still tell it's a Buffer | string, but we won't necessarily compute the members of the union itself (i.e. the intersection of members on Buffer and string).
Also, members are always computed for types directly referenced from the AST, for example, if some expression is inferred to have the type A & B, that type is fully extracted, members and all, but A and B themselves might be shallow.
(edited for a better example)
asger-semmle
force-pushed
the
ts-infinite-expansion
branch
from
ca1dbee to
16a2177
Compare
|
Rebased on 1.20. I'm not sure a change note is warranted, given that not many people use full-mode extraction anyway. |
Fixes a problem observed when extracting DefinitelyTyped in full mode.