Skip to content

Swift: Add ClassOrStructDecl class #10595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

MathiasVP
Copy link
Contributor

This PR adds a class that's defined as the union of ClassDecl and StructDecl`. This is motivated by us having used the wrong one of these on several occasions.

Hopefully, by instead relying on this union class, we'll be less likely to run into these issues.

@MathiasVP MathiasVP requested a review from a team as a code owner September 27, 2022 16:54
@MathiasVP MathiasVP added the no-change-note-required This PR does not need a change note label Sep 27, 2022
@MathiasVP MathiasVP requested a review from geoffw0 September 28, 2022 08:57
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this!

@geoffw0 geoffw0 merged commit e196caa into github:main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-change-note-required This PR does not need a change note Swift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants