Java: Type based summary models. #10628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
java/ql/src/utils/model-generator/internal/CaptureTypeBasedSummaryModels.qll
Fixed
Show fixed
Hide fixed
java/ql/src/utils/model-generator/internal/CaptureTypeBasedSummaryModels.qll
Fixed
Show fixed
Hide fixed
java/ql/src/utils/model-generator/internal/CaptureTypeBasedSummaryModels.qll
Fixed
Show fixed
Hide fixed
java/ql/src/utils/model-generator/internal/CaptureTypeBasedSummaryModels.qll
Fixed
Show fixed
Hide fixed
java/ql/src/utils/model-generator/internal/CaptureTypeBasedSummaryModels.qll
Fixed
Show fixed
Hide fixed
michaelnebel
force-pushed
the
java/typebasedmodels
branch
2 times, most recently
from
85f21ca to
4668c55
Compare
java/ql/src/utils/model-generator/internal/CaptureTypeBasedSummaryModels.qll
Fixed
Show fixed
Hide fixed
java/ql/src/utils/model-generator/internal/CaptureTypeBasedSummaryModels.qll
Fixed
Show fixed
Hide fixed
java/ql/src/utils/model-generator/internal/CaptureTypeBasedSummaryModels.qll
Fixed
Show fixed
Hide fixed
michaelnebel
force-pushed
the
java/typebasedmodels
branch
from
3e0bdbe to
01016f6
Compare
java/ql/src/utils/model-generator/internal/CaptureTypeBasedSummaryModels.qll
Fixed
Show fixed
Hide fixed
java/ql/src/utils/model-generator/internal/CaptureTypeBasedSummaryModels.qll
Fixed
Show fixed
Hide fixed
michaelnebel
force-pushed
the
java/typebasedmodels
branch
from
f488cc6 to
69cc0ba
Compare
michaelnebel
added
the
no-change-note-required
michaelnebel
force-pushed
the
java/typebasedmodels
branch
from
b1a9464 to
f40e1d7
Compare
aschackmull
reviewed
Oct 12, 2022
aschackmull
reviewed
Oct 12, 2022
java/ql/test/utils/model-generator/typebasedflow/p/TypeBasedComplex.java
Show resolved
Hide resolved
aschackmull
reviewed
Oct 12, 2022
java/ql/test/utils/model-generator/typebasedflow/CaptureTypeBasedSummaryModels.expected
Outdated
Show resolved
Hide resolved
michaelnebel
force-pushed
the
java/typebasedmodels
branch
from
aee3ddd to
384e2f7
Compare
aschackmull
reviewed
Nov 4, 2022
java/ql/test/utils/model-generator/typebasedflow/CaptureTypeBasedSummaryModels.ql
Outdated
Show resolved
Hide resolved
aschackmull
reviewed
Nov 4, 2022
java/ql/test/utils/model-generator/typebasedflow/CaptureTypeBasedSummaryModels.ql
Outdated
Show resolved
Hide resolved
aschackmull
reviewed
Nov 4, 2022
aschackmull
reviewed
Nov 4, 2022
aschackmull
reviewed
Nov 4, 2022
aschackmull
reviewed
Nov 4, 2022
aschackmull
reviewed
Nov 4, 2022
aschackmull
reviewed
Nov 4, 2022
java/ql/src/utils/modelgenerator/internal/CaptureTypeBasedSummaryModels.qll
Outdated
Show resolved
Hide resolved
aschackmull
reviewed
Nov 4, 2022
java/ql/src/utils/modelgenerator/internal/CaptureTypeBasedSummaryModels.qll
Outdated
Show resolved
Hide resolved
aschackmull
reviewed
Nov 4, 2022
|
|
||
| /** | ||
| * Holds if `t` is a container like type of `tv` (eg. `List<T>`). | ||
| * Note that collections are covariant in their element type. |
There was a problem hiding this comment.
No? In Java they aren't. Or is this something that you assume for some heuristic purpose?
There was a problem hiding this comment.
Ok, that claim is to strong.
At least the idea is that, if we have "relevant" type variable that serves as an upper bound for a given type, then we use that to eg. decide if the method reads from an implicit field or the implicit collection.
I will delete the comment.
There was a problem hiding this comment.
haha - no - you are right! I will try once more :-)
…t happy with the generated result.
…ents to comments.
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>
michaelnebel
force-pushed
the
java/typebasedmodels
branch
from
ef82d05 to
8041542
Compare
aschackmull
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we introduce the a query for generating type based models for Java.
This is the Java version of #10238.
It is worth mentioning the following differences.
Funcordelegatelike type, but instead relies on functional interfaces (ie. interfaces with a single abstract method) as these can be perceived as functions, which complicated the implementation compared to C#.java.util.stream.Streamis used (an approximate equivalent to theSystem.Linq.Enumerableextension methods for C#).