Kotlin: Add a ministdlib test #10633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make it easier to diagnose certain kinds of problems.
tamasvajk
previously approved these changes
Oct 3, 2022
| open operator fun equals(other: Any?): Boolean { return this.equals(other) } | ||
| } | ||
|
|
||
| public open class String { |
There was a problem hiding this comment.
Why are String, Boolean, and Int declared as open?
There was a problem hiding this comment.
Ah, I'd just made everything an open class without checking. Fixed, thanks!
| infix fun xor(other: Int): Int { return this.xor(other) } | ||
| } | ||
|
|
||
| public open class Unit { |
There was a problem hiding this comment.
Shouldn't this match more closely the stdlib, so shouldn't it be public object Unit?
tamasvajk
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it easier to diagnose certain kinds of problems.