Skip to content

Java: Fix cartesian product #10640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

atorralba
Copy link
Contributor

Fixes a cartesian product in the canThrow predicate, where callable wasn't bound in one side of the disjunct.

@atorralba atorralba requested a review from a team as a code owner September 30, 2022 08:48
@github-actions github-actions bot added the Java label Sep 30, 2022
@atorralba atorralba added the no-change-note-required This PR does not need a change note label Sep 30, 2022
@aschackmull
Copy link
Contributor

The fix only affects one query, so you could have just selected that in dca.

Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@atorralba atorralba merged commit 683cacb into github:main Oct 3, 2022
@atorralba atorralba deleted the atorralba/fix-cartesian-product branch October 3, 2022 06:56
atorralba added a commit that referenced this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants