Skip to content

C#: Recognize options to dotnet run in tracer when injecting -p:UseSharedCompilation=false #10667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2022
Merged

C#: Recognize options to dotnet run in tracer when injecting -p:UseSharedCompilation=false #10667

merged 2 commits into from
Oct 4, 2022

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Oct 4, 2022 •
edited
Loading

Invocations like

dotnet run --no-build arg

would incorrectly be rewritten to

dotnet run -p:UseSharedCompilation=false -- --no-build arg

With this PR, they instead get rewritten to

dotnet run -p:UseSharedCompilation=false --no-build arg

@hvitved hvitved changed the title C#: Recognize options to dotnet run in tracer when injecting -p:UseSharedCompilation=false C#: Recognize options to dotnet run in tracer when injecting -p:UseSharedCompilation=false Oct 4, 2022
@github-actions github-actions bot added the C# label Oct 4, 2022
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Oct 4, 2022
@hvitved hvitved marked this pull request as ready for review October 4, 2022 08:28
@hvitved hvitved requested a review from a team as a code owner October 4, 2022 08:28
michaelnebel
michaelnebel approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right!
Command line options are complicated 😹
LGTM!

@hvitved hvitved merged commit 321c858 into github:main Oct 4, 2022
@hvitved hvitved deleted the csharp/dotnet-run-tracer-fix2 branch October 4, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelnebel michaelnebel michaelnebel approved these changes

Assignees
No one assigned
Labels
C# no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvitved @michaelnebel