Kotlin: allow building a single embeddable plugin version #10712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
force-pushed
the
smowton/admin/kotlin-allow-single-embeddable-version
branch
from
17cdf85 to
d9fe9bb
Compare
smowton
force-pushed
the
smowton/admin/kotlin-allow-single-embeddable-version
branch
from
d9fe9bb to
bb6e575
Compare
igfoo
reviewed
Oct 7, 2022
java/kotlin-extractor/build.py
Outdated
| elif args.many: | ||
| for version in kotlin_plugin_versions.many_versions: | ||
| compile_standalone(version) | ||
| compile_embeddable(version) | ||
| else: | ||
| compile_standalone(kotlin_plugin_versions.get_single_version()) | ||
| compile_single_version(kotlin_plugin_versions.get_single_version()) |
There was a problem hiding this comment.
I'm not sure it makes sense to support --single-version-embeddable without --single-version, in which case compile_single_version could be inlined into the args.single_version case.
igfoo
previously approved these changes
Oct 7, 2022
igfoo
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.