Skip to content

Ruby: Move SummarizedCallableFromModel into ModelsAsData.qll #10763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2022
Merged

Ruby: Move SummarizedCallableFromModel into ModelsAsData.qll #10763

merged 1 commit into from
Oct 11, 2022

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Oct 11, 2022

I think the adapter class fits more naturally in ModelsAsData.qll.

@github-actions github-actions bot added the Ruby label Oct 11, 2022
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Oct 11, 2022
@hvitved hvitved marked this pull request as ready for review October 11, 2022 09:14
@hvitved hvitved requested a review from a team as a code owner October 11, 2022 09:14
@hvitved hvitved merged commit 878654e into github:main Oct 11, 2022
@hvitved hvitved deleted the ruby/move-summarized-callable-from-model branch October 11, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aibaars aibaars aibaars approved these changes

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvitved @aibaars