Ruby: model Pathname#existence extension from ActiveSupport
#10784
Conversation
alexrford
added
no-change-note-required
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| override predicate row(string row) { | ||
| // package1;type1;package2;type2;path | ||
| // Pathname#existence : Pathname | ||
| row = ";Pathname;;Pathname;Method[existence].ReturnValue" |
There was a problem hiding this comment.
You could use activesupport as the package name here - I don't think it does any harm and we do that for some of the other rails libraries already.
Scrap that - Pathname is a stdlib class so you're right not to have a package name here.
There was a problem hiding this comment.
(sorry if this isn't ready for review btw - I didn't notice it was still a draft until now)
There was a problem hiding this comment.
Thanks, I wasn't quite sure what our policy was here. I've specified activesupport as the package name in all the cases here involving existence and added an "activesupport;Pathname;;Pathname;" type definition to maintain the existing Pathname related flow when using the existence method.
I missed the updated comment here - reverted.
alexrford
force-pushed
the
ruby/pathname-existence
branch
from
12a27cc to
bf4dac7
Compare
https://api.rubyonrails.org/classes/Pathname.html