Rb: add case-when expressions as a sink to rb/polynomial-redos #10798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibaars
previously approved these changes
Oct 13, 2022
| matchNode.asExpr() = caseWhen and | ||
| this.asExpr() = caseWhen.getValue() and | ||
| regexp.asExpr() = | ||
| caseWhen.getBranch(_).(CfgNodes::ExprNodes::WhenClauseCfgNode).getPattern(_) |
There was a problem hiding this comment.
Shall we also add regular expressions in InClauses?
aibaars
approved these changes
Oct 13, 2022
|
A new evaluation came in, it looks the same as the previous evaluation. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CVE-2021-22880: Recognizes the sink (TP with #10782).
CVE-2022-30122: One step closer to the sink.
Evaluation looks OK.
There is a hint towards a performance regression, but I couldn't replicate locally.
And a repeat shows a smaller regression, and in other projects 🤷