Skip to content

Swift: extract all ImplicitConversionExpr #10854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

redsun82
Copy link
Contributor

In order to do so, VisitorBase was changed to allow writing one translate function for an abstract class like ImplicitConversionExpr.

As there is one point in code extracting all ImplicitConversionExpr, there is also now only one generated test for those (using the pragma qltest.collapse_hierarchy). The test however does not cover yet all implicit conversions (but it is still better coverage than before).

In order to do so, `VisitorBase` was changed to allow writing one
`translate` function for an abstract class like
`ImplicitConversionExpr`.
@redsun82 redsun82 requested a review from a team as a code owner October 17, 2022 11:00
@github-actions github-actions bot added the Swift label Oct 17, 2022
@redsun82 redsun82 merged commit c3968a2 into main Oct 17, 2022
@redsun82 redsun82 deleted the redsun82/swift-extract-implicit-conversions branch October 17, 2022 11:46
@geoffw0
Copy link
Contributor

geoffw0 commented Oct 17, 2022

This fixes the issue I was hitting on #10757 , giving us many more results for the query. Thanks!

Copy link

@randydwhitephotography randydwhitephotography left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants