Kotlin: Refactor PSI handling #10894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were giving warnings about comments, when we were actually trying to populate numlines.
smowton
previously approved these changes
Oct 19, 2022
Comment on lines
19
to
24
| val psi2Ir = getPsi2Ir(logger) | ||
| init { | ||
| if (psi2Ir == null) { | ||
| logger.warn("Lines of code will not be populated as Kotlin version is too old (${KotlinCompilerVersion.getVersion()})") | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| val psi2Ir = getPsi2Ir(logger) | |
| init { | |
| if (psi2Ir == null) { | |
| logger.warn("Lines of code will not be populated as Kotlin version is too old (${KotlinCompilerVersion.getVersion()})") | |
| } | |
| } | |
| val psi2Ir = getPsi2Ir(logger) ?: run { | |
| logger.warn("Lines of code will not be populated as Kotlin version is too old (${KotlinCompilerVersion.getVersion()})") | |
| } |
There was a problem hiding this comment.
I think that this would also need a ; null in the run to get the right result. I've switched it to use .also instead, which I think is nicer than a separate init block. It doesn't get us the concise ?: null check, but I think that it's more natural to "also" do something that doesn't have a result.
smowton
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were giving warnings about comments, when we were actually trying to populate numlines.