Skip to content

Java: Fix some join-orders. #10904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2022
Merged

Java: Fix some join-orders. #10904

merged 1 commit into from
Nov 4, 2022

Conversation

aschackmull
Copy link
Contributor

More easy wins.

@aschackmull aschackmull added the no-change-note-required This PR does not need a change note label Oct 20, 2022
@aschackmull aschackmull requested a review from a team as a code owner October 20, 2022 12:24
@github-actions github-actions bot added the Java label Oct 20, 2022
@aschackmull
Copy link
Contributor Author

dca looks uneventful

atorralba
atorralba approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@atorralba atorralba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible to me. Do we need to hold off merging until the new CLI release?

@aschackmull
Copy link
Contributor Author

Do we need to hold off merging until the new CLI release?

This depends on 2.11.2, which has been out for a bit now and 2.11.3 is coming soon, so I think it should be fine to merge by now.

@aschackmull aschackmull merged commit 331b8c0 into github:main Nov 4, 2022
@aschackmull aschackmull deleted the java/joinorders branch November 4, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@atorralba atorralba atorralba approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Java no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aschackmull @atorralba @codeql-ci