Ruby: handle compound constant-assignment #10918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgerf
added a commit
to asgerf/codeql
that referenced
this pull request
Oct 23, 2022
From this PR: github#10918
asgerf
commented
Oct 24, 2022
There was a problem hiding this comment.
Thanks for fixing this @aibaars! I did a slow and steady read through the implementation and AFAICT everything looks good.
The evaluation backlinked above looks great, neutral perf, +250 call edges, and +15 sinks.
However, I can't approve my own PR. Feel free to post an approval yourself 😄
asgerf
changed the title
aibaars
approved these changes
Oct 24, 2022
hvitved
reviewed
Nov 1, 2022
Comment on lines
+894
to
+898
| // constant accesses with scope expression in compound assignments are desugared | ||
| not ( | ||
| this = any(AssignOperation op).getLeftOperand() and | ||
| exists(this.getScopeExpr()) | ||
| ) |
There was a problem hiding this comment.
@aibaars : It would be better to use Synthesis::excludeFromControlFlowTree for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kudos to @aibaars for the implementation (pushed directly to this PR).
Constants can be used in compound assignments but were not previously desugared, creating holes in the CFG: