Swift: WebView JS-native bridge sources #11027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atorralba
commented
Oct 28, 2022
This is what contains externally-provided data in Webview JS-native bridges
atorralba
force-pushed
the
atorralba/swift/webview-js-native-bridge-sources
branch
from
5557744 to
5ef8f9c
Compare
Better model the JSExport protocol logic
atorralba
force-pushed
the
atorralba/swift/webview-js-native-bridge-sources
branch
from
5ef8f9c to
baf7986
Compare
geoffw0
reviewed
Oct 28, 2022
Model the source as an access to the tainted field, instead of the field itself (which didn't work)
geoffw0
approved these changes
Oct 31, 2022
atorralba
deleted the
atorralba/swift/webview-js-native-bridge-sources
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds taint sources for JS-native bridges in WebViews. These are objects where JavaScript running in the WebView can execute native code, which can be exploited by malicious websites, or external attackers through XSS vulnerabilities, if it performs sensitive actions.