Ruby: Model various ActionController methods #11058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmac
force-pushed
the
actioncontroller-logger
branch
from
9f29317 to
4bea04b
Compare
hmac
changed the title
hmac
force-pushed
the
actioncontroller-logger
branch
2 times, most recently
from
c0c6c3a to
8ccce80
Compare
nickrolfe
previously approved these changes
Nov 7, 2022
|
That run shows a stage timing (?) slowdown for |
That is a fluke that you shouldn't worry about. But you have merge conflicts beyond the test-files that GitHub is complaining about (e.g. |
This test shows that we correctly identify redirect_to and render calls inside respond_to blocks.
The behaviour of `Object#inspect` depends on whether it has been overridden by a subclass, but it will typically produce output on a single line. Calling `inspect` on a String will replace newlines with `\n`, which is then safe for interpolation into a log line.
hmac
force-pushed
the
actioncontroller-logger
branch
from
8ccce80 to
ed3270f
Compare
erik-krogh
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActionControllermethods have access to aloggermethod which returns an instance ofActiveSupport::Logger.The first commit moves the existing
ActionController.qltest to be inside theaction_controllerdirectory, so that is no longer affected by changes to other test fixtures. I think we should probably do this for the remaining tests (ActionDispatch, ActionView, Core, GraphQL, PosixSpawn) at some point.Later commits model
send_dataandbody_stream.Evaluation shows new TPs for log injection, with one FP due to us not considering
Object#inspectto be a sanitizer. I've added a commit to fix this FP.