Skip to content

Conversation

atorralba
Copy link
Contributor

This removes the necessity of importing an internal dataflow file to be able to use the Unit class.

@@ -1,9 +1,14 @@
/**
* Provides Swift-specific definitions for use in the data flow library.
*/

import swift as Swift
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be private?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, just realized it 😅 Fixed in 978ed03, thanks for pointing it out.

@atorralba atorralba force-pushed the atorralba/swift/unit branch from 4c2a6da to 978ed03 Compare November 3, 2022 10:19
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atorralba atorralba merged commit 83caf01 into github:main Nov 3, 2022
@atorralba atorralba deleted the atorralba/swift/unit branch November 3, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants