Skip to content

C++: Also taint the return value dereference in the strcat model #11159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2022
Merged

C++: Also taint the return value dereference in the strcat model #11159

merged 1 commit into from
Nov 8, 2022
+23 −15

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Nov 8, 2022

No description provided.

@jketema jketema requested a review from a team as a code owner November 8, 2022 11:10
@github-actions github-actions bot added the C++ label Nov 8, 2022
MathiasVP
MathiasVP approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM! As this could create some new alerts it would be nice to run this on DCA before we merge it though.

Edit: Which I see you're already doing 😂. Great!

@jketema
Copy link
Contributor Author

jketema commented Nov 8, 2022

Do we need a change note, you think?

@MathiasVP
Copy link
Contributor

Do we need a change note, you think?

Nah, I don't think we've done this in the past for simple model fixes, at least.

@jketema jketema added the no-change-note-required This PR does not need a change note label Nov 8, 2022
@jketema
Copy link
Contributor Author

jketema commented Nov 8, 2022

DCA looks good. No changes in alert counts.

@jketema jketema merged commit d93bda2 into github:main Nov 8, 2022
@jketema jketema deleted the strcat-return-deref-taint branch November 8, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathiasVP MathiasVP MathiasVP approved these changes

Assignees
No one assigned
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jketema @MathiasVP