Ruby: generalise summaries for ActiveSupport Hash extensions #11166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
reviewed
Nov 9, 2022
| ReverseMergeSummary() { this = ["reverse_merge", "with_defaults"] } | ||
|
|
||
| override predicate propagatesFlowExt(string input, string output, boolean preservesValue) { | ||
| input = ["Argument[self]", "Argument[0]"] and |
There was a problem hiding this comment.
Are we missing a .WithElement here?
There was a problem hiding this comment.
Yeah. After some thought I've put the old summaries back (the ones that are specific to the context of ActionController params), and then made these general summaries use WithElement.
| ReverseMergeBangSummary() { this = ["reverse_merge!", "with_defaults!", "reverse_update"] } | ||
|
|
||
| override predicate propagatesFlowExt(string input, string output, boolean preservesValue) { | ||
| input = ["Argument[self]", "Argument[0]"] and |
- revert the changes to the taint summaries specific to ActionController params - make the general flow summaries value-preserving and use WithElement[any]
hvitved
previously approved these changes
Nov 9, 2022
|
DCA shows a bad row under stage timings. I don't really know what to make of that. But I need to resolve conflicts anyway, so I'll kick off another run after that. |
hvitved
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.