Swift: fix synthesized wrapper decls #11231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are synthesized
VarDeclandPatternBindingDeclrelated to property wrappers that were not correctly placed in the AST tree, which amonf other things was causing flakiness of thePrintAsttest.This fixes that, by placing these entities under the
VarDeclintroducing them.Both the IDE
printAst.qlquery and the testtoBeTestedpredicate have also been extended to include descendants even when these do not have a location.Commit by commit review is encouraged. The first commit is only a
schema.pychange.This is the relevant change to the
PrintAst.expectedfile that can help explaining most of the PR:41977d1#diff-0fbb63a98340427775b9c85b0b287275acaa40d0d7ce263393c604c253db0425