Skip to content

delete old deprecations #11318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 19, 2022
Merged

delete old deprecations #11318

merged 9 commits into from
Nov 19, 2022

Conversation

erik-krogh
Copy link
Contributor

@erik-krogh erik-krogh commented Nov 17, 2022 •
edited
Loading

This time with change-notes.

I deleted deprecations where the deprecated annotation is at least 14 months old according to git blame.

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 17, 2022
View reviewed changes
@erik-krogh erik-krogh changed the title delete more deprecations delete old deprecations Nov 17, 2022
@erik-krogh erik-krogh marked this pull request as ready for review November 17, 2022 23:07
@erik-krogh erik-krogh requested review from a team as code owners November 17, 2022 23:07
hvitved
hvitved approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C# 👍

geoffw0
geoffw0 approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++ LGTM.

tausbn
tausbn approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 👍

asgerf
asgerf approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@asgerf asgerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS 👍

aschackmull
aschackmull approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java 👍

@erik-krogh erik-krogh merged commit a69524f into github:main Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asgerf asgerf asgerf approved these changes

@tausbn tausbn tausbn approved these changes

@hvitved hvitved hvitved approved these changes

@aschackmull aschackmull aschackmull approved these changes

@geoffw0 geoffw0 geoffw0 approved these changes

Assignees
No one assigned
Labels
C# C++ documentation Java JS Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@erik-krogh @asgerf @tausbn @hvitved @aschackmull @geoffw0