Ruby: Active support enumerable #11339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibaars
force-pushed
the
active_support_enumerable
branch
from
7c005ac to
f1371f1
Compare
hvitved
reviewed
Nov 29, 2022
| exists(string s, int i | | ||
| s = getKeyArgument(mc, i) and | ||
| input = "Argument[self].Element[0].Element[" + s + "!]" and | ||
| output = "ReturnValue.Element[" + i + "!]" |
| override MethodCall getACall() { result = mc } | ||
|
|
||
| override predicate propagatesFlowExt(string input, string output, boolean preservesValue) { | ||
| input = "Argument[self].Element[0].Element[" + key + "!]" and |
There was a problem hiding this comment.
I don't think we want the ! here.
| override predicate propagatesFlowExt(string input, string output, boolean preservesValue) { | ||
| exists(string s, int i | | ||
| s = getKeyArgument(mc, i) and | ||
| input = "Argument[self].Element[0].Element[" + s + "!]" and |
There was a problem hiding this comment.
I don't think we want the ! here.
| override MethodCall getACall() { result = mc } | ||
|
|
||
| override predicate propagatesFlowExt(string input, string output, boolean preservesValue) { | ||
| input = "Argument[self].Element[any].Element[" + key + "!]" and |
Comment on lines
418
to
419
| input = "Argument[self].Element[any].Element[" + s + "!]" and | ||
| output = "ReturnValue.Element[?].Element[" + i + "!]" |
aibaars
force-pushed
the
active_support_enumerable
branch
from
265c045 to
6103c57
Compare
hvitved
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.