CFG: Workaround in test output for origin/target pairs with multiple edges #11341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
changed the title
aibaars
reviewed
Nov 21, 2022
| @@ -811,7 +811,7 @@ case.rb: | |||
| #-----| -> [ ..., * ] | |||
|
|
|||
| # 35| [ ..., * ] | |||
| #-----| match -> x | |||
| #-----| false, match, true -> x | |||
There was a problem hiding this comment.
Is this actually right? I wonder where the true and false edges come from.
There was a problem hiding this comment.
No, this is a bug. It may be addressed already by @hmac's CFG changes, but in all cases, I think we should handle it follow-up.
aibaars
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that
@kind graphqueries do not currently support multiple edges with the same origin and target (but distinguished by label), so we were missing CFG edges in the test output for C#, Ruby, and Swift.