Swift: Add models for NSData and NSMutableData #11378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffw0
previously approved these changes
Nov 24, 2022
swift/ql/lib/codeql/swift/frameworks/StandardLibrary/NSData.qll
Outdated
Show resolved
Hide resolved
geoffw0
approved these changes
Nov 24, 2022
MathiasVP
reviewed
Nov 24, 2022
| @@ -0,0 +1 @@ | |||
| | nsdata.swift:110:45:110:45 | bytes | Unexpected result: tainted=108 | | |||
There was a problem hiding this comment.
We're missing a $ on the // tainted=108 comment.
There was a problem hiding this comment.
🤦♂️ sorry. Fixed here #11411.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that models requiring flow through code blocks have been left out (see
TODOcomments).