Skip to content

C#: ExternalFlow.qll cleanup. #11395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 24, 2022

Conversation

michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Nov 23, 2022

In this PR we delete the bi-directional import of ExternalFlow that was needed to include all models defined in the framework specific files.
It turned out that some other parts of the code relied on the SCC that was generated from the bi-directional import. Most cases were fixed on #10777 and this PR fixes the remaining one and deletes all the un-needed import code.

@github-actions github-actions bot added the C# label Nov 23, 2022
@michaelnebel michaelnebel force-pushed the csharp/externalflowcleanup branch from 33b05f9 to 311614c Compare November 23, 2022 14:03
@michaelnebel michaelnebel marked this pull request as ready for review November 23, 2022 16:35
@michaelnebel michaelnebel requested a review from a team as a code owner November 23, 2022 16:35
@michaelnebel michaelnebel added the no-change-note-required This PR does not need a change note label Nov 23, 2022
@michaelnebel
Copy link
Contributor Author

michaelnebel commented Nov 23, 2022

Will trigger DCA to see, if we experience any performance issues by untying the SCC knot.

@michaelnebel
Copy link
Contributor Author

DCA Looks good!

Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@michaelnebel michaelnebel merged commit cb4a7e2 into github:main Nov 24, 2022
@michaelnebel michaelnebel deleted the csharp/externalflowcleanup branch November 24, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants