Skip to content

LGTM deprecation: updates to CodeQL for JavaScript articles #11419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

felicitymay
Copy link
Contributor

@felicitymay felicitymay commented Nov 24, 2022

This pull request updates the language guides for JavaScript to remove references to LGTM.

As far as I can tell, most of the references can be removed without substitution. If I've misjudged this, please let me know.

This is one of many pull requests. I've raised a separate pull request to update the "Basic query" articles so that they guide users through get started running queries in VS Code. This should help offset the removal of the links to the query console: #11423.

@felicitymay felicitymay requested a review from a team November 24, 2022 20:54
hubwriter
hubwriter previously approved these changes Nov 28, 2022
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍

erik-krogh
erik-krogh previously approved these changes Nov 28, 2022
Copy link
Contributor

@erik-krogh erik-krogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aibaars aibaars dismissed stale reviews from erik-krogh and hubwriter via 7e5a9fb November 28, 2022 14:41
@aibaars aibaars force-pushed the felicitymay-8441-query-guides-javascript branch from 3246030 to 7e5a9fb Compare November 28, 2022 14:41
@aibaars aibaars changed the base branch from main to rc/3.8 November 28, 2022 14:42
@erik-krogh erik-krogh merged commit ae40b0a into rc/3.8 Nov 28, 2022
@erik-krogh erik-krogh deleted the felicitymay-8441-query-guides-javascript branch November 28, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants