Skip to content

LGTM deprecation: updates to CodeQL for C/C++ articles #11421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 29, 2022

Conversation

felicitymay
Copy link
Contributor

@felicitymay felicitymay commented Nov 24, 2022

This pull request updates the language guides for C/C++ to remove references to LGTM.

As far as I can tell, most of the references can be removed without substitution. If I've misjudged this, please let me know.

This is one of many pull requests. I've raised a separate pull request to update the "Basic query" articles so that they guide users through get started running queries in VS Code. This should help offset the removal of the links to the query console: #11423.

@felicitymay felicitymay requested a review from a team November 24, 2022 21:04
jketema
jketema previously approved these changes Nov 25, 2022
hubwriter
hubwriter previously approved these changes Nov 28, 2022
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@felicitymay felicitymay dismissed stale reviews from hubwriter and jketema via 03b5ef1 November 28, 2022 12:41
@github-actions github-actions bot removed the C++ label Nov 28, 2022
jketema
jketema previously approved these changes Nov 28, 2022
@aibaars aibaars force-pushed the felicitymay-8441-query-guides-c branch from 03b5ef1 to 85961f5 Compare November 28, 2022 14:36
@aibaars aibaars changed the base branch from main to rc/3.8 November 28, 2022 14:36
@jketema
Copy link
Contributor

jketema commented Nov 28, 2022

@aibaars This now has non-c++ changes in it. Is that what you wanted?

@aibaars
Copy link
Contributor

aibaars commented Nov 28, 2022

@aibaars This now has non-c++ changes in it. Is that what you wanted?

I think that is because @felicitymay had pushed some small other changes: main...03b5ef1

@felicitymay
Copy link
Contributor Author

Thanks for checking @jketema. The changes required for those languages were so small, that I thought that it would be okay to add them to this PR.

@jketema
Copy link
Contributor

jketema commented Nov 28, 2022

The changes required for those languages were so small, that I thought that it would be okay to add them to this PR.

It's fine. I was just wondering if this was by accident. Anyway, all looks good to me.

@felicitymay felicitymay merged commit 114d337 into rc/3.8 Nov 29, 2022
@felicitymay felicitymay deleted the felicitymay-8441-query-guides-c branch November 29, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants