Skip to content

Make qldoc clearer about behaviour of override #11431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Nov 25, 2022

The example that prompted this change was e.getTarget().hasQualifiedName("a","b"), where e is a CallExpr. Because the result of getTarget is a Function and the override is on its subclass Method, the documentation for the override on Method is not readily available. Since the behaviour is quite different for Method, we note it in the documentation of the original predicate.

@owen-mc owen-mc added the no-change-note-required This PR does not need a change note label Nov 25, 2022
@owen-mc owen-mc requested a review from tibbes November 25, 2022 12:36
@owen-mc owen-mc requested a review from a team as a code owner November 25, 2022 12:36
@github-actions github-actions bot added the Go label Nov 25, 2022
@owen-mc owen-mc merged commit d3e06ee into github:main Dec 2, 2022
@owen-mc owen-mc deleted the go/update-qldoc branch December 2, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Go no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants