Skip to content

C#: Add integration test that checks whether env vars are passed through autobuilder #11449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Nov 28, 2022

An integration test for verifying that all environment variables get passed through the C# auto-builder.

@github-actions github-actions bot added the C# label Nov 28, 2022
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Nov 28, 2022
@hvitved hvitved marked this pull request as ready for review November 28, 2022 12:18
@hvitved hvitved requested a review from a team as a code owner November 28, 2022 12:18
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@@ -0,0 +1,2 @@
cp $PROJECT_TO_BUILD temp.csproj
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you are testing that the build script invoked by the autobuilder can use system environment variables?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@hvitved hvitved merged commit b075c55 into github:main Nov 29, 2022
@hvitved hvitved deleted the csharp/autobuild-env-vars-integration-test branch November 29, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants