Swift: extract missing cases of AccessorKind and AccessSemantics enums
#11450
Conversation
There was a problem hiding this comment.
LGTM! I've been meaning to fix this for a long time. Thanks for doing it 🙇!
For future reference: When creating PRs that consist of both autogenerated and manually-written code it's super helpful when the PR is split into commits that are clearly marked as "this commit is totally autogenerated", or "this commit is totally handwritten".
MathiasVP
dismissed
their stale review
Oh, right. We need to write upgrade and downgrade scripts now. So we need to do that before we can merge it.
|
Right, I'll get onto the upgrade script. FYI the .cpp and .py files are the manually written ones. |
d10c
force-pushed
the
swift/missing-enum-cases
branch
from
ba9c537 to
043e9a1
Compare
|
Wrote the upgrade script. Though I'm not sure if it really works for updating old DBs, since I get the old "The database may be too new for the QL libraries the query is using; try upgrading them" error when following the testing steps here 🤔 |
i.e. "TrapLabel not found"
By initializing va_list the standard way, i.e. leaving it uninitialized until va_start().
This resolves the warnings that were showing up during extractor-pack compilation.
d10c
force-pushed
the
swift/missing-enum-cases
branch
from
043e9a1 to
93cce0f
Compare
|
Updated tests + |
|
LGTM once the test changes are accepted 😄. |
|
I also started an experiment here just to be sure there are no surprises https://github.com/github/codeql-dca-main/issues/8905 |
|
DCA looks fine. Merging! |
This resolves the "missing switch case" warnings that were showing up while compiling the swift extractor pack.