Skip to content

Conversation

redsun82
Copy link
Contributor

Also, moved from Makefile to a bash source.

Also, moved from Makefile to a bash source.
@redsun82 redsun82 requested a review from AlexDenisov November 30, 2022 16:48
@redsun82 redsun82 requested a review from a team as a code owner November 30, 2022 16:48
@github-actions github-actions bot added the Swift label Nov 30, 2022
Copy link
Contributor

@AlexDenisov AlexDenisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though it's unclear what the rationale behind

Also, moved from Makefile to a bash source.

?

@redsun82
Copy link
Contributor Author

redsun82 commented Dec 1, 2022

LGTM, though it's unclear what the rationale behind

Also, moved from Makefile to a bash source.

?

Since 95% of that makefile was actually bash, I think it's just more direct to have it in bash from the get go. Also, I dislike semantic tabs 😅

@redsun82 redsun82 merged commit 4ac9c87 into main Dec 1, 2022
@redsun82 redsun82 deleted the redsun82/swift-frontend-invocations branch December 1, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants