-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Java: Cleanup imports of ExternalFlow
#11516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: Cleanup imports of ExternalFlow
#11516
Conversation
480c20f
to
c0ea053
Compare
c715e44
to
27f2379
Compare
c3cb945
to
fa5a94a
Compare
fa5a94a
to
6e486d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good to me, thanks for doing this! I added a couple NITs (that you can completely ignore), and one minor fix.
Wondering if this is worth a DCA run 🤔 (when it works). |
This is definitely worth a DCA run! We need to see if there are any sudden drops in performance (or improvements). |
DCA looks good.
Merging now. |
In this PR we cleanup the bi-directional framework imports that were introduced for Models as Data.
The bi-directional imports created a huge SCC of dependencies and removing the importa revealed some missing imports in other parts of the code that were relying on the framework SCC in
ExternalFlow.qll
.The code has been modified accordingly and bi-directional imports because of other abstract classes have been introduced where needed.