Skip to content

Swift: resolve symlinks conditionally #11523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2022
Merged

Swift: resolve symlinks conditionally #11523

merged 2 commits into from
Dec 2, 2022

Conversation

AlexDenisov
Copy link
Contributor

No description provided.

@AlexDenisov AlexDenisov requested a review from redsun82 December 1, 2022 15:32
@AlexDenisov AlexDenisov requested a review from a team as a code owner December 1, 2022 15:32
@github-actions github-actions bot added the Swift label Dec 1, 2022
redsun82
redsun82 reviewed Dec 1, 2022
View reviewed changes
Copy link
Contributor

@redsun82 redsun82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we can really commit symlinks to this repo to avoid problems checking this out on Windows, so maybe the symlinks need to be set up by test.py (and .gitignored)

@AlexDenisov AlexDenisov force-pushed the alexdenisov/preserve-symlinks branch from d3447b5 to 1d8a9f2 Compare December 2, 2022 09:02
@AlexDenisov AlexDenisov force-pushed the alexdenisov/preserve-symlinks branch from 1d8a9f2 to 7a3beac Compare December 2, 2022 09:07
redsun82
redsun82 reviewed Dec 2, 2022
View reviewed changes
redsun82
redsun82 reviewed Dec 2, 2022
View reviewed changes
@AlexDenisov AlexDenisov force-pushed the alexdenisov/preserve-symlinks branch from bdec132 to 7a3beac Compare December 2, 2022 11:42
@AlexDenisov
Copy link
Contributor Author

AlexDenisov commented Dec 2, 2022 •
edited
Loading

@redsun82 I reverted the suggestions as they broke something once again.

@redsun82
Copy link
Contributor

redsun82 commented Dec 2, 2022

@redsun82 I reverted the suggestions as they broke something once again.

sorry! I'm also ok with reverting and pushing as is, we can change this later, they were only nits either way

@AlexDenisov AlexDenisov mentioned this pull request Dec 2, 2022
Merged
@AlexDenisov AlexDenisov merged commit 691188b into main Dec 2, 2022
@AlexDenisov AlexDenisov deleted the alexdenisov/preserve-symlinks branch December 2, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redsun82 redsun82 redsun82 approved these changes

Assignees
No one assigned
Labels
Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexDenisov @redsun82