C++: Performance fix for cpp/cleartext-storage-buffer #11596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
reviewed
Dec 7, 2022
Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com>
MathiasVP
approved these changes
Dec 7, 2022
|
DCA LGTM - a good number of speedups for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a performance issue with
cpp/cleartext-storage-buffer, that was causing it to fail on several LGTM projects. The issue was that one of the constraints on the sink (that the written buffer is aSensitiveExpr) was only expressed in the query, not in the dataflow configuration. The solution is to define the sources properly. Following that and a bit more cleanup, I also believe the result is more readable than what we had before.Improves performance on
mruby_mrubylocally from ~750s to ~45s.I will also do a DCA run on this pull request.