C++: Define the argv flow source in terms the input parameter
#11693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
previously approved these changes
Dec 15, 2022
jketema
force-pushed
the
argv-param-flowsource
branch
from
c9f2540 to
fab912b
Compare
jketema
force-pushed
the
argv-param-flowsource
branch
from
fab912b to
edd29f4
Compare
jketema
changed the base branch from
mathiasvp/replace-ast-with-ir-use-usedataflow
to
main
|
Rebased and now targeting |
|
Apologies for pinging many people. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently missing some updates to expected test results, but I'd like to see the impact on DCA before fixing those.I manually verified that the spurious cases from #11677 (comment) are now gone, and that the alert there only has the
argvparameter as its source (as was to be expected).The issue with
mainthat is fixed in one of the test cases caused theargvparameter each of themains to be reported as flow source in the othermains. The same issue should not occur in real codebases, as in those eachmainfunction and its parameters should be in a separate link target.