JS: support push and sort taint steps for arrays
#117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
self-requested a review
as a 
|
No new results or performance changes for big-apps.slugs internal link. |
|
Two FPs for js/remote-property-injection on default.slugs, but this PR is not the root cause of that (internal link). Removing WIP label. |
|
Intriguing; are the FPs due to deficiencies of the query? |
|
See analysis in the gist |
|
OK, merging. |
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Dec 6, 2021
Kotlin: Improve builtin support
erik-krogh
pushed a commit
to erik-krogh/ql
that referenced
this pull request
Dec 15, 2021
…erator Upgrade the extractor generator
erik-krogh
pushed a commit
to erik-krogh/ql
that referenced
this pull request
Dec 15, 2021
…-generator Upgrade the extractor generator
MathiasVP
pushed a commit
to MathiasVP/ql
that referenced
this pull request
Aug 10, 2025
Fixing a false positive in cs/insecure-sql-connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds taint steps for
Array.prototype.sortandArray.prototype.pushcalls.Tagging for 1.18, but marking as WIP, as performance is still being evaluated.
The
pushstep is flow-insensitive, I am curious about how that will work play out in practice.